It's the scripting issues, the production problems, the legal battles that were ongoing and the constant pulling and tugging in different directions form all over the place. The producer basically disappeared on set and it was his first feature. It was a very difficult and unhappy set and barely managed to get to the finish line.
The task largely fell to Kershner and Connery to get the darn thing finished and it is their efforts that resulted in a finished picture at all. They came up with great bits and the good parts of the scripts that still work are the best parts of the film.
Everyone in the production should have been entirely on the same page and they weren't and it kills the film's effectiveness. What works are the riffs on the official series, the sense of fun sprinkled throughout, the witticisms of the different screenplays that make it through and both Connery and Brandauer's performances which are sublime. It's the definition of a wasted opportunity and mixed bag.
Even the look of the film is quite flat which is surprising as it was shot by Douglas Slocombe post Raiders. The pacing is dead in the water, the tone is too relaxed, there is an almost TV movie feel throughout, the flat contrasty look of video editions does not help, many of the performances are off the mark or underwhelming etc. Kim Basinger is useless as Domino and literally has one facial expression for the whole film.
The action actually is one thing that works fine. Nothing special and the underwater finale is beyond uninspired but the fight in Shurblands is overepic, the opening is ok if a bit cheesy, and the shark attack is inspired and all done for real.
The best scene in the whole film is the Domination game. The best official series joke is the new Q. The glorious golden gem of the film is Nigel Small Fawcett.
Don't get me wrong I've come to appreciate the film's strengths over the years and watch it after my series re-watch at least once a year with CR 67. But the more you read on the production history it was just impossible to pull together. We're lucky we got anything at all.